-
-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to use latest audio and subtitles #4514
base: master
Are you sure you want to change the base?
feat: Add ability to use latest audio and subtitles #4514
Conversation
75c568e
to
1546856
Compare
Looks like an alternative to waiting for #3754, which appears stale |
Just like #3754, this shouldn't need preferences in the client but could be default behavior. Although to be fair, I believe this behavior would be better suited for the server. We already ask it for the (subtitle/audio) streams to use and it already knows we played a previous episode of the same series with a specific subtitle/audio stream. If the change was made on the server it would result in a better experience across all clients. |
I added preferences:
If you prefer, I can remove preferences and let it as default behavior. What do you think @nielsvanvelzen? |
(If a non-server approach is used) this looks a lot better than what I had in #3754 . I struggled getting playback to actually play, but this looks like it doesn't have the issue I did. I do think I could get behind the server approach for this though. Makes more sense to have the server calculate this in one place the consuming clients could use |
Yeah default behavior would be better, no one would watch an episode in 1 language and another episode in another language, once set, it should stick by default. And I do agree that this is better implemented server side (per user), but if this is the only solution right now, I'd take it as long as this change is reverted once/if a server side solution is implemented later. |
3cbcb6a
to
0b64ebc
Compare
0b64ebc
to
fef9711
Compare
Set as default options. Also created jellyfin/jellyfin#13794 to use it once it's solved |
Changes
Add ability to remember audio and subtitle languages from last played episode. By enabling correspondent option in settings section, every new episode played will take into account last played episode to select audio and/or subtitles track.